-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logcat tests and disable upgrade-app test #9030
Conversation
Serhy
commented
Sep 24, 2019
•
edited by StatusWrike
Loading
edited by StatusWrike
- we had often false failing test_logcat_backup_recovery_phrase test. It was checking whether any of two words, used as confirmation to back up seed phrase, are present in logcat. If any of two is present test fails. Issue is that in dictionary for seed-phrases there are many words which are used as normal log items: for example "talk" or "list" or "icon" and many more. So we modified the test to check whether both words are in logcat
- test_send_eth_from_wallet_incorrect_address updated so no ERROR in Jenkins.
- upgrade_app test disabled (no upgrade support for now anyway)
Pull Request Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Jenkins Builds
|
98% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (45)Click to expand |
91% of end-end tests have passed
Failed tests (8)Click to expand
Passed tests (85)Click to expand
|
Signed-off-by: Serhy <sergii@status.im>
27b36d1
to
0a5acfb
Compare